Changeset 1528 in ExiteCMS for modules/common/download_statistics/php-files/modules/download_statistics/report.topfiles.php

Timestamp:

07/07/08 17:53:43 (4 years ago)

Author:

hverton

Message:

test if the report query is correct and whould produce any results before showing it

File:

• modules/common/download_statistics/php-files/modules/download_statistics/report.topfiles.php (modified) (1 diff)

modules/common/download_statistics/php-files/modules/download_statistics/report.topfiles.php

@@ -80 +80 @@
 
             // check how many rows this would output
-            $rptresult = dbquery($sql.($top ? (" LIMIT 0,".$top) : ""));
-            // store some row counter for the pager
-            $variables['rows'] = dbrows($rptresult);
-            $variables['rowstart'] = $rowstart;
+            $rptresult = mysql_query($sql);
+            if ($rptresult) {
+                // store some row counter for the pager
+                $variables['rows'] = dbrows($rptresult);
+                $variables['rowstart'] = $rowstart;
 
-            // now add a query limit, make sure not to overshoot the limit requested
-            if ($top > 0 && $rowstart+$settings['numofthreads'] > $top) {
-                $rowstart = max(0, $limit - $settings['numofthreads']);
+                // now add a query limit, make sure not to overshoot the limit requested
+                if ($top > 0 && $rowstart+$settings['numofthreads'] > $top) {
+                    $rowstart = max(0, $limit - $settings['numofthreads']);
+                } else {
+                    // technically, this is never going to be the limit ;-)
+                    $top = 99999999999999;
+                }
+                $rptresult = dbquery($sql." LIMIT ".$rowstart.",".min($rowstart+$top, $settings['numofthreads']));
+
+                // get the results
+                $reportvars['output'] = array();
+                while ($rptdata = dbarray($rptresult)) {
+                    $reportvars['output'][] = $rptdata;
+                }
             } else {
-                // technically, this is never going to be the limit ;-)
-                $top = 99999999999999;
+                $variables['message'] = $locale['dls950']." ".mysql_error();
             }
-            $rptresult = dbquery($sql." LIMIT ".$rowstart.",".min($rowstart+$top, $settings['numofthreads']));
-
-            // get the results
-            $reportvars['output'] = array();
-            while ($rptdata = dbarray($rptresult)) {
-                $reportvars['output'][] = $rptdata;
-            }
-
         }
     }