Changeset 1062 in ExiteCMS

Timestamp:

11/05/07 21:46:49 (4 years ago)

Author:

hverton

Message:

Modified the newsletters module so that no newsletters are send to deactivated or suspended member accounts, or member accounts which an invalid email address. A count of invalid email addresses is shown in the progress status panel after the newsletter has been sent.

Location:

modules/common/newsletters/php-files/modules/newsletters

Files:

• locale/English.php (modified) (1 diff)
• newsletters.php (modified) (5 diffs)

modules/common/newsletters/php-files/modules/newsletters/locale/English.php

@@ -28 +28 @@
 $locale['nl423'] = "Newsletter Copied";
 $locale['nl424'] = "A preview of the newsletter has been sent successfully to your email address.";
+$locale['nl425'] = "%s newsletters could not be sent due to an invalid email address.";
 // Add/Edit Newsletter Form
 $locale['nl430'] = "Subject:";

modules/common/newsletters/php-files/modules/newsletters/newsletters.php

@@ -156 +156 @@
 
     // build the query on the user table based on the selection made
-    $query = "SELECT * FROM ".$db_prefix."users WHERE";
+    $query = "SELECT * FROM ".$db_prefix."users WHERE user_status = 0 AND ";
     $where = "";
     if ($send_to_myself) {
@@ -181 +181 @@
     $result2 = dbquery($query);
 
-    
-    $error = ""; $sc = 0;
+    // process the selected users
+    $error = ""; $sc = 0; $bad_email = 0;
     if (dbrows($result2) == 0) {
         $error = $locale['nl419'];
@@ -192 +192 @@
         $error = array();
         while($data2 = dbarray($result2)) {
+
+            // check if this user has an invalid email address flag
+            if ($data2['user_bad_email'] != 0) {
+                // update the counter, and skip this user
+                $bad_email++;
+                continue;
+            }
+
+            // replace tags in the subject
             $subject = stripslashes($data['newsletter_subject']);
-            // replace tags in the subject
             $subject = str_replace("{:USER_NAME:}", $data2['user_name'], $subject);
 
+            // replace tags in the body
             $content = stripslashes($data['newsletter_content']);
-            // replace tags in the body
             $content = str_replace("{:USER_ID:}", $data2['user_id'], $content);
             $content = str_replace("{:USER_NAME:}", $data2['user_name'], $content);
@@ -283 +291 @@
 
     // process the error messages
-    $variables['message'] = "<b>";
+    $variables['message'] = "";
     if (is_array($error)) {
         if ($send_to_myself) {
@@ -300 +308 @@
     } else {
         $variables['message'] .= $error;
+    }
+    if ($bad_email) {
+        $variables['message'] .= "<br /><br />".sprintf($locale['nl425'], $bad_email);
     }
     $variables['bold'] = true;